aaron/infra-core
1
0
Fork 2
Code Issues Pull requests 12 Projects Releases 1 Packages Wiki Activity Actions

HOMELAB-1053: remove lab-director — chart, manifests, ESO, ArgoCD RBAC, OTel + dormant refs #203

Merged
aaron merged 2 commits from homelab-1053-remove-lab-director into live 2026-05-11 21:14:42 +00:00
Conversation 1 Commits 2 Files changed 21 +7 -871
aaron commented 2026-05-10 21:47:37 +00:00
Owner
Copy link

Plane

HOMELAB-1053

⚠️ Dependency

MUST be merged AFTER the prod PR (HOMELAB-1053-remove-lab-director on aaron/prod) has merged AND ArgoCD has finished pruning lab-director + cnpg-cluster-lab-director.

Confirm before merging:

argocd app list | grep lab-director
# → must return empty

Chart removal

  • core/charts/apps/lab-director/ — Entire Helm chart (Chart.yaml, 7 templates, values.yaml)

Manifest deletions

  • core/manifests/apps/lab-director-pg-lb.yaml — Orphan LoadBalancer Service (not ArgoCD-managed)
  • core/manifests/external-secrets/es-lab-director-worker.yaml — 7 ExternalSecrets in lab-director namespace

ExternalSecrets cleanup

  • core/manifests/external-secrets/es-cnpg-b2.yaml — Removed lab-director ExternalSecret doc. 6 remaining namespaces: forgejo, zitadel, outline, langfuse, temporal, apexdirector-timescale.

ArgoCD RBAC

  • core/charts/platform/argocd/values.yaml — Removed 4 policy.csv lines for lab-director subject (create/delete/get/sync on dev-agents/*)

OTel collector

  • core/charts/platform/opentelemetry-collector/values.yaml — Removed and service.name != "lab-director" from span filter (no-op cleanup)

Dormant sandbox chart refs

  • core/charts/apps/sandbox/values.yaml — Removed LAB_DIRECTOR_API_URL, replaced Harbor image with REPLACE_ME placeholder
  • core/charts/apps/sandbox/templates/ciliumnetworkpolicy.yaml — Removed egress allow rule to lab-director:8080
  • core/charts/apps/sandbox/templates/deployment.yaml — Removed LAB_DIRECTOR_API_URL env var

Dormant dev-environment chart ref

  • core/charts/apps/dev-environment/values.yaml — Replaced Harbor image with REPLACE_ME placeholder
## Plane [HOMELAB-1053](https://plane.aaron.reynoza.org/) ## ⚠️ Dependency **MUST be merged AFTER the prod PR (HOMELAB-1053-remove-lab-director on aaron/prod) has merged AND ArgoCD has finished pruning lab-director + cnpg-cluster-lab-director.** Confirm before merging: ```bash argocd app list | grep lab-director # → must return empty ``` --- ## Chart removal - `core/charts/apps/lab-director/` — Entire Helm chart (Chart.yaml, 7 templates, values.yaml) ## Manifest deletions - `core/manifests/apps/lab-director-pg-lb.yaml` — Orphan LoadBalancer Service (not ArgoCD-managed) - `core/manifests/external-secrets/es-lab-director-worker.yaml` — 7 ExternalSecrets in lab-director namespace ## ExternalSecrets cleanup - `core/manifests/external-secrets/es-cnpg-b2.yaml` — Removed lab-director ExternalSecret doc. 6 remaining namespaces: forgejo, zitadel, outline, langfuse, temporal, apexdirector-timescale. ## ArgoCD RBAC - `core/charts/platform/argocd/values.yaml` — Removed 4 policy.csv lines for lab-director subject (create/delete/get/sync on dev-agents/*) ## OTel collector - `core/charts/platform/opentelemetry-collector/values.yaml` — Removed `and service.name != "lab-director"` from span filter (no-op cleanup) ## Dormant sandbox chart refs - `core/charts/apps/sandbox/values.yaml` — Removed LAB_DIRECTOR_API_URL, replaced Harbor image with REPLACE_ME placeholder - `core/charts/apps/sandbox/templates/ciliumnetworkpolicy.yaml` — Removed egress allow rule to lab-director:8080 - `core/charts/apps/sandbox/templates/deployment.yaml` — Removed LAB_DIRECTOR_API_URL env var ## Dormant dev-environment chart ref - `core/charts/apps/dev-environment/values.yaml` — Replaced Harbor image with REPLACE_ME placeholder
HOMELAB-1053: remove lab-director — chart, manifests, ESO, ArgoCD RBAC, OTel + dormant refs
Some checks are pending
CI Review / pr-title (pull_request) Waiting to run
Details
CI Review / helm-validate (pull_request) Waiting to run
Details
CI Review / ai-review (pull_request) Waiting to run
Details
Lint & Validate / terraform-validate (pull_request) Waiting to run
Details
Lint & Validate / yaml-lint (pull_request) Waiting to run
Details
Lint & Validate / shellcheck (pull_request) Waiting to run
Details
0/0 projects applied successfully.
de38095e02 
- Delete lab-director Helm chart (core/charts/apps/lab-director/)
- Delete orphan LB Service manifest (lab-director-pg-lb.yaml)
- Delete worker ExternalSecrets (es-lab-director-worker.yaml)
- Remove lab-director ExternalSecret doc from es-cnpg-b2.yaml (6 remaining namespaces)
- Remove lab-director ArgoCD RBAC policy.csv entries (4 lines)
- Remove lab-director from OTel collector span filter
- Clean dormant sandbox chart refs: LAB_DIRECTOR_API_URL, image registry, CNP egress allow
- Clean dormant dev-environment chart ref: Harbor image path

MUST be merged AFTER prod PR has merged AND ArgoCD has pruned lab-director/cnpg-cluster-lab-director.
Confirm 'argocd app list | grep lab-director' returns empty before merging.
HOMELAB-1053: amend — retire NATS chart, delete missed ExternalSecret
Some checks failed
CI Review / pr-title (pull_request) Has been cancelled
Details
CI Review / helm-validate (pull_request) Has been cancelled
Details
CI Review / ai-review (pull_request) Has been cancelled
Details
Lint & Validate / terraform-validate (pull_request) Has been cancelled
Details
Lint & Validate / yaml-lint (pull_request) Has been cancelled
Details
Lint & Validate / shellcheck (pull_request) Has been cancelled
Details
3e3031562e 
- Delete core/manifests/external-secrets/es-lab-director-argocd.yaml (missed in initial scan; would cause external-secrets-config app to go Degraded after ns deletion)
- Delete core/charts/apps/nats/values.yaml (NATS retired alongside lab-director)
- Delete core/charts/platform/nats/values.yaml (duplicate NATS values overlay)
aaron commented 2026-05-11 02:39:48 +00:00
Author
Owner
Copy link

Amendment commit 3e30315

Added scope per follow-up review:

Missed ExternalSecret (HIGH-severity finding — would have caused external-secrets-config Application to go Degraded after Phase 3 namespace deletion)

  • Delete core/manifests/external-secrets/es-lab-director-argocd.yaml

NATS chart retirement (scout confirmed: lab-director was the only consumer)

  • Delete core/charts/apps/nats/values.yaml
  • Delete core/charts/platform/nats/values.yaml (duplicate overlay)

Updated diff: 21 files (was 18). The merge ordering dependency (after prod PR + ArgoCD prune) is unchanged.

## Amendment commit `3e30315` Added scope per follow-up review: **Missed ExternalSecret** (HIGH-severity finding — would have caused `external-secrets-config` Application to go Degraded after Phase 3 namespace deletion) - Delete `core/manifests/external-secrets/es-lab-director-argocd.yaml` **NATS chart retirement** (scout confirmed: lab-director was the only consumer) - Delete `core/charts/apps/nats/values.yaml` - Delete `core/charts/platform/nats/values.yaml` (duplicate overlay) Updated diff: **21 files** (was 18). The merge ordering dependency (after prod PR + ArgoCD prune) is unchanged.
aaron merged commit cf7421d69d into live 2026-05-11 21:14:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aaron/infra-core!203
No description provided.