aaron/infra-core
1
0
Fork 1
Code Issues Pull requests 11 Projects Releases 1 Packages Wiki Activity Actions

HOMELAB-568: fix(monitoring): replace invalid for: 0m with valid durations in Prometheus alerts #146

Open
aaron wants to merge 1 commit from plane/HOMELAB-568-fix-prometheus-for-syntax into live
pull from: plane/HOMELAB-568-fix-prometheus-for-syntax
merge into: aaron:live
Conversation 0 Commits 1 Files changed 3 +3 -3
aaron commented 2026-04-02 20:42:45 +00:00
Owner
Copy link

Summary

  • Fix invalid for: 0m syntax in Prometheus alert rules that was blocking alert evaluation
  • Replace with valid durations: PodCrashLooping (1m), PrometheusWALCorruption (1m), OOMKillRateHigh (5m)

Root Cause

Promotheus does not accept for: 0m as a valid duration. This invalid syntax was preventing critical alerts from firing:

  • PodCrashLooping (critical)
  • PrometheusWALCorruption (critical)
  • OOMKillRateHigh (warning)

Files Changed

  • core/manifests/monitoring/rules/pod-alerts.yaml - PodCrashLooping: 0m → 1m
  • core/manifests/monitoring/rules/capacity-alerts.yaml - OOMKillRateHigh: 0m → 5m
  • core/manifests/monitoring/rules/observability-alerts.yaml - PrometheusWALCorruption: 0m → 1m

Test Plan

  • Alert rules validate with proper Prometheus syntax
  • Deploy to cluster and verify alerts can fire
  • Monitor AlertManager for successful alert evaluation

🤖 Generated with Claude Code

Closes HOMELAB-568

## Summary - Fix invalid `for: 0m` syntax in Prometheus alert rules that was blocking alert evaluation - Replace with valid durations: PodCrashLooping (1m), PrometheusWALCorruption (1m), OOMKillRateHigh (5m) ## Root Cause Promotheus does not accept `for: 0m` as a valid duration. This invalid syntax was preventing critical alerts from firing: - PodCrashLooping (critical) - PrometheusWALCorruption (critical) - OOMKillRateHigh (warning) ## Files Changed - `core/manifests/monitoring/rules/pod-alerts.yaml` - PodCrashLooping: `0m` → `1m` - `core/manifests/monitoring/rules/capacity-alerts.yaml` - OOMKillRateHigh: `0m` → `5m` - `core/manifests/monitoring/rules/observability-alerts.yaml` - PrometheusWALCorruption: `0m` → `1m` ## Test Plan - [x] Alert rules validate with proper Prometheus syntax - [ ] Deploy to cluster and verify alerts can fire - [ ] Monitor AlertManager for successful alert evaluation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Closes HOMELAB-568
HOMELAB-568: fix(monitoring): replace invalid 'for: 0m' with valid durations in Prometheus alerts
Some checks failed
0/0 projects applied successfully.
CI Review / ai-review (pull_request) Has been cancelled
Details
CI Review / helm-validate (pull_request) Has been cancelled
Details
CI Review / pr-title (pull_request) Has been cancelled
Details
Lint & Validate / shellcheck (pull_request) Has been cancelled
Details
Lint & Validate / yaml-lint (pull_request) Has been cancelled
Details
Lint & Validate / terraform-validate (pull_request) Has been cancelled
Details
b64bb4a24e 
- PodCrashLooping: for: 0m -> for: 1m (critical severity, immediate detection)
- PrometheusWALCorruption: for: 0m -> for: 1m (critical severity, immediate detection)
- OOMKillRateHigh: for: 0m -> for: 5m (warning severity, reduce flapping)

Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
Some checks failed
0/0 projects applied successfully.
CI Review / ai-review (pull_request) Has been cancelled
Details
CI Review / helm-validate (pull_request) Has been cancelled
Details
CI Review / pr-title (pull_request) Has been cancelled
Details
Lint & Validate / shellcheck (pull_request) Has been cancelled
Details
Lint & Validate / yaml-lint (pull_request) Has been cancelled
Details
Lint & Validate / terraform-validate (pull_request) Has been cancelled
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin plane/HOMELAB-568-fix-prometheus-for-syntax:plane/HOMELAB-568-fix-prometheus-for-syntax
git switch plane/HOMELAB-568-fix-prometheus-for-syntax
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aaron/infra-core!146
No description provided.