aaron/infra-core
1
0
Fork 2
Code Issues Pull requests 12 Projects Releases 1 Packages Wiki Activity Actions

HOMELAB-990: fix(talos-cluster): drop triggers from wait_for_nodes #193

Merged
aaron merged 1 commit from plane/HOMELAB-990-drop-wait-triggers into live 2026-04-26 07:30:12 +00:00
Conversation 0 Commits 1 Files changed 1 +6 -6
aaron commented 2026-04-26 07:30:10 +00:00
Owner
Copy link

Quick fix to #192. The triggers I added cause terraform plan to want to replace null_resource.wait_for_nodes on first apply after state mv (state has empty triggers, code adds 4 → forced replace). wait_for_nodes is one-shot bootstrap, no triggers needed. Verified locally that removing them eliminates the spurious replacement.

Quick fix to #192. The triggers I added cause terraform plan to want to replace null_resource.wait_for_nodes on first apply after state mv (state has empty triggers, code adds 4 → forced replace). wait_for_nodes is one-shot bootstrap, no triggers needed. Verified locally that removing them eliminates the spurious replacement.
HOMELAB-990: fix(talos-cluster): drop triggers from wait_for_nodes
Some checks failed
0/0 projects applied successfully.
CI Review / pr-title (pull_request) Has been cancelled
Details
CI Review / helm-validate (pull_request) Has been cancelled
Details
CI Review / ai-review (pull_request) Has been cancelled
Details
Lint & Validate / terraform-validate (pull_request) Has been cancelled
Details
Lint & Validate / yaml-lint (pull_request) Has been cancelled
Details
Lint & Validate / shellcheck (pull_request) Has been cancelled
Details
1b767fe3e9 
The triggers I added in #192 (expected_node_count, kubeconfig_sha,
timeout_seconds, script_version) caused terraform plan to want to
replace the existing null_resource on first apply after the state mv,
because the prior state has empty triggers and any non-empty triggers
map forces replacement.

wait_for_nodes is a one-shot bootstrap concern: run once on cluster
create, never re-fire. The dependency on local_file.kubeconfig +
helm_release.cilium already provides the right ordering. Triggers
buy us nothing here.

Verified locally that without triggers, terraform plan no longer
wants to replace the resource.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
aaron merged commit 46539d936a into live 2026-04-26 07:30:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aaron/infra-core!193
No description provided.