aaron/infra-core
1
0
Fork 2
Code Issues Pull requests 12 Projects Releases 1 Packages Wiki Activity Actions

HOMELAB-516: Hardcode SANDBOX_MODE=true in sandbox deployment #113

Merged
claude-agent merged 1 commit from plane/HOMELAB-516-sandbox-env-vars into live 2026-04-01 00:04:55 +00:00
Conversation 0 Commits 1 Files changed 2 +1 -2
claude-agent commented 2026-04-01 00:04:48 +00:00
Owner
Copy link

Summary

  • Hardcode SANDBOX_MODE=true in deployment.yaml instead of sourcing from values
  • Remove SANDBOX_MODE from values.yaml env section (not overridable — always true for sandboxes)
  • SANDBOX_NAME already correctly sourced from sandbox.name (set by Supervisor via ArgoCD params)

Verification

  • helm template confirms both env vars render correctly
  • Supervisor already passes sandbox.name as ArgoCD Helm parameter (confirmed in argocd.go L105)
## Summary - Hardcode `SANDBOX_MODE=true` in deployment.yaml instead of sourcing from values - Remove `SANDBOX_MODE` from values.yaml env section (not overridable — always true for sandboxes) - `SANDBOX_NAME` already correctly sourced from `sandbox.name` (set by Supervisor via ArgoCD params) ## Verification - `helm template` confirms both env vars render correctly - Supervisor already passes `sandbox.name` as ArgoCD Helm parameter (confirmed in argocd.go L105)
HOMELAB-516: fix(sandbox): hardcode SANDBOX_MODE=true in deployment template
Some checks failed
0/0 projects applied successfully.
CI Review / ai-review (pull_request) Has been cancelled
Details
CI Review / helm-validate (pull_request) Has been cancelled
Details
CI Review / pr-title (pull_request) Has been cancelled
Details
Lint & Validate / shellcheck (pull_request) Has been cancelled
Details
Lint & Validate / yaml-lint (pull_request) Has been cancelled
Details
Lint & Validate / terraform-validate (pull_request) Has been cancelled
Details
7bb9f46e6f 
SANDBOX_MODE should always be "true" for sandbox deployments — remove from
values.yaml env section and hardcode in deployment.yaml to prevent accidental
override. SANDBOX_NAME already correctly sourced from sandbox.name.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
aaron/infra-core!113
No description provided.